Skip to content

Fix factorial issues #5496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2021
Merged

Fix factorial issues #5496

merged 6 commits into from
Oct 21, 2021

Conversation

poyea
Copy link
Member

@poyea poyea commented Oct 21, 2021 •
edited by cclauss
Loading

https://github.com/TheAlgorithms/Python/runs/3958162685?check_suite_focus=true#step:3:5

In Python 3.10

math.factorial(x)
    Return x factorial as an integer. Raises ValueError if x is not integral or is negative.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@poyea poyea requested review from cclauss and Panquesito7 October 21, 2021 03:50
@poyea poyea self-assigned this Oct 21, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 21, 2021
@poyea poyea changed the title Fix project euler problem 15 Fix factorial issues Oct 21, 2021
This was referenced Oct 21, 2021
Closed
Merged
Closed
Merged
Closed
Merged
Merged
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 21, 2021
@github-actions github-actions bot force-pushed the fix-project-euler-problem-15 branch from 3351675 to 258816d Compare October 21, 2021 06:59
@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 21, 2021
@poyea poyea merged commit c0acfd4 into master Oct 21, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2021
@poyea poyea deleted the fix-project-euler-problem-15 branch October 21, 2021 07:06
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@poyea @cclauss @shermanhui
Fix factorial issues (TheAlgorithms#5496)
11517ed 
* updating DIRECTORY.md

* pass integer to `math.factorial` in `project_euler/problem_015`

* remove duplicated factorial function

* updating DIRECTORY.md

* Update maths/factorial_iterative.py

Co-authored-by: Christian Clauss <[email protected]>

* Update factorial_iterative.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poyea @cclauss